Skip to content

fix(datastore): Add missing onError handlers#2844

Open
mattcreaser wants to merge 12 commits intomainfrom
mattcreaser/rxlint
Open

fix(datastore): Add missing onError handlers#2844
mattcreaser wants to merge 12 commits intomainfrom
mattcreaser/rxlint

Conversation

@mattcreaser
Copy link
Member

@mattcreaser mattcreaser commented Jun 10, 2024

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:
#2817

Description of changes:

  • Added RxLint lint checks. These checks highlight potential RxJava errors such as missing error handlers.
  • Resolved all RxLint errors

How did you test these changes?

  • Manual testing

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner June 10, 2024 18:20
vincetran
vincetran previously approved these changes Jun 10, 2024
View reviewed changes
@mattcreaser mattcreaser enabled auto-merge (squash) July 10, 2024 14:27
@mattcreaser
Copy link
Member Author

mattcreaser commented Aug 12, 2024

This PR is failing on some integration tests. I will try to investigate when I get time.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 48.78049% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.76%. Comparing base (7c69d6e) to head (ec20116).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2844      +/-   ##
==========================================
- Coverage   54.79%   54.76%   -0.03%     
==========================================
  Files        1049     1049              
  Lines       31361    31380      +19     
  Branches     4695     4696       +1     
==========================================
+ Hits        17184    17186       +2     
- Misses      12368    12383      +15     
- Partials     1809     1811       +2
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tylerjroach tylerjroach tylerjroach approved these changes

@vincetran vincetran vincetran approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mattcreaser @tylerjroach @vincetran @edisooon @jvh-aws

Comments